Fix build and doc issues#1
Open
yamasite wants to merge 3 commits into
Open
Conversation
With this change, this project can at least build. But a problem remains.
I used the room id and user id that generate the temp token:
```js
function checkRoomIdAndUserId(name) {
$(`#${name}`).keyup(() => {
let ret = checkReg(name)
console.log(ret)
});
}
```
ret is false.
But the login window pops out again and again
yamasite
commented
Jul 1, 2022
| * before join a room, you should create a room,then you can join it with `engine.join(token,roomId,uid, onSuccessFunc, onFailFunc)` | ||
| */ | ||
| await rtc.join((config.token || {})[config.uid], config.roomId, config.uid); | ||
| await rtc.join((config.token || {}), config.roomId, config.uid); |
Author
There was a problem hiding this comment.
This change fixed the remaining bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, this project can at least build. But a problem remains.
I used the room id and user id that generate the temp token:
ret is false.
But the login window pops out again and again. Weird behavior.